Added the junit test cases for CustomSearchNarrowingInterceptor #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamparikh927
approved these changes
Aug 29, 2023
hankwallace
requested changes
Aug 29, 2023
…r-jpaserver-starter into junit-tests-for-CustomSearchNarrowingInterceptor
hankwallace
requested changes
Oct 19, 2023
| public void before() throws IOException { | ||
| MockitoAnnotations.openMocks(this); | ||
| ourReturn = Collections.emptyList(); | ||
| ourLastHitMethod = null; |
There was a problem hiding this comment.
Why would you want to test the "last hit method"?
There was a problem hiding this comment.
I have followed the upstream repo tests, as when we search for fhirResource( observation or patient ), the variable ourLastHitMethod will return the method name we have hit so it helps to verify right method has been called during execution.
| @Override | ||
| protected AuthorizedList buildAuthorizedList(RequestDetails theRequestDetails) { | ||
| try (MockedStatic<OAuth2Helper> mockedStatic = mockStatic(OAuth2Helper.class)) { | ||
| mockedStatic.when(() -> OAuth2Helper.hasToken(any())).thenReturn(true); |
There was a problem hiding this comment.
Mocking, and replacing, the functionality of the OAuth2Helper invalidates the entire test. Tests SHOULD NOT know about the helper.
…r-jpaserver-starter into junit-tests-for-CustomSearchNarrowingInterceptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
How it was tested
Checklist